Thread (8 messages) 8 messages, 1 author, 2021-05-31

Re: [PATCH 2/4] thunderbolt: usb4: Fix NVM read buffer bounds and offset issue

From: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: 2021-05-20 08:54:56

On Mon, May 17, 2021 at 02:59:05PM +0300, Mika Westerberg wrote:
From: Mathias Nyman <redacted>

Up to 64 bytes of data can be read from NVM in one go.
Read address must be dword aligned. Data is read into a local buffer.

If caller asks to read data starting at an unaligned address then full
dword is anyway read from NVM into a local buffer. Data is then copied
from the local buffer starting at the unaligned offset to the caller
buffer.

In cases where asked data length + unaligned offset is over 64 bytes
we need to make sure we don't read past the 64 bytes in the local
buffer when copying to caller buffer, and make sure that we don't
skip copying unaligned offset bytes from local buffer anymore after
the first round of 64 byte NVM data read.

Fixes: b04079837b20 ("thunderbolt: Add initial support for USB4")
Cc: stable@vger.kernel.org
Signed-off-by: Mathias Nyman <redacted>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied to thunderbolt.git/fixes.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help