Re: Re: Re: Re: [PATCH] HID: usbhid: enable remote wakeup for mouse

On Mon, May 17, 2021 at 06:52:37PM +0800, 马强 wrote:

quoted

quoted

quoted

quoted

quoted

quoted

quoted

quoted

Thanks for the prompt response.  
 
We can change "dev->power.should_wakeup" to enabled,  

 
I do not understand this statement.  
 

quoted

but ultimately it depends on the hardware and BIOS for wakeup.  

 
Yes, and the hardware here (USB mice), do not all support this, so you  
can not enable it universally as it will cause problems, right?  

 
I mean, the kernel should set should_wakeup to enabled  
 
so that system can be awakened when the hardware here(USB mice) supports

the  

quoted

quoted

wake-up ability.  

And how do you determine, in the kernel, if the mouse can do that?  

What range of hardware did you test this change with?  

 
At the kernel level, "dev->power.should_wakeup" is the device property

that should enable the wake-up capability. 

Given that you have not tested this change, why should we take this?