Re: [PATCH] usb: storage: datafab: remove redundant assignment of variable result
From: Alan Stern <stern@rowland.harvard.edu>
Date: 2021-04-20 14:34:16
Also in:
kernel-janitors, lkml
On Tue, Apr 20, 2021 at 12:38:18PM +0100, Colin King wrote:
From: Colin Ian King <redacted>
The variable result is being assigned with a value that is
never read, the assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>
---Acked-by: Alan Stern <stern@rowland.harvard.edu>
quoted hunk ↗ jump to hunk
drivers/usb/storage/datafab.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/usb/storage/datafab.c b/drivers/usb/storage/datafab.c index 588818483f4b..bcc4a2fad863 100644 --- a/drivers/usb/storage/datafab.c +++ b/drivers/usb/storage/datafab.c@@ -294,7 +294,6 @@ static int datafab_write_data(struct us_data *us, if (reply[0] != 0x50 && reply[1] != 0) { usb_stor_dbg(us, "Gah! write return code: %02x %02x\n", reply[0], reply[1]); - result = USB_STOR_TRANSPORT_ERROR; goto leave; }-- 2.30.2