Thread (3 messages) 3 messages, 2 authors, 2021-03-27

Re: [PATCH v2] usb: dwc3: core: don't enable wakeup for runtime PM

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-03-26 13:39:49

On Wed, Mar 24, 2021 at 01:18:25PM +0800, Li Jun wrote:
quoted hunk ↗ jump to hunk
Don't enable dwc3 core to wakeup system by default if runtime suspended,
this will make the power domain of dwc3 core or its parent device can't be
off while system sleep even system wakeup by usb is not required.

Fixes: fc8bb91bc83e ("usb: dwc3: implement runtime PM")
Cc: <redacted>
Signed-off-by: Li Jun <redacted>
---
Change for v2:
- Add fix tag and cc to stable kernel.

 drivers/usb/dwc3/core.c | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 94fdbe502ce9..0bba5c21de56 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1840,8 +1840,6 @@ static int dwc3_runtime_suspend(struct device *dev)
 	if (ret)
 		return ret;
 
-	device_init_wakeup(dev, true);
-
 	return 0;
 }
 
@@ -1850,8 +1848,6 @@ static int dwc3_runtime_resume(struct device *dev)
 	struct dwc3     *dwc = dev_get_drvdata(dev);
 	int		ret;
 
-	device_init_wakeup(dev, false);
-
 	ret = dwc3_resume_common(dwc, PMSG_AUTO_RESUME);
 	if (ret)
 		return ret;
-- 
2.25.1
Can I get some verification by other users of this driver that this
actually fixes something?  I find it odd it's not shown up yet to anyone
else...

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help