Re: [RFC PATCH] USB:ohci:fix ohci interruption problem
From: Alan Stern <stern@rowland.harvard.edu>
Date: 2021-03-29 15:26:41
Also in:
lkml
From: Alan Stern <stern@rowland.harvard.edu>
Date: 2021-03-29 15:26:41
Also in:
lkml
On Mon, Mar 29, 2021 at 04:38:10PM +0800, liulongfang wrote:
On 2021/3/26 23:28, Alan Stern wrote:quoted
On Fri, Mar 26, 2021 at 04:54:56PM +0800, Longfang Liu wrote:quoted
When OHCI enters the S4 sleep state, the USB sleep process will call check_root_hub_suspend() and ohci_bus_suspend() instead of ohci_suspend() and ohci_bus_suspend(), this causes the OHCI interrupt to not be closed.What on earth are you talking about? This isn't true at all. Can you provide more information about your system? Are you using a PCI-based OHCI controller or a platform device (and if so, which one)? Can you post system logs to back up your statements? The system is UOS, the kernel version is kernel4.19, and the driverused is ohci-pci.c based on PCI. By adding the log in ohci_suspend, and then viewing the dmesg after sleep, I can confirm that the system does not call ohci_suspend in S4 sleep mode.
Then your job is to figure out why not. Doesn't entry into S4 sleep call hcd_pci_suspend() in core/hcd-pci.c, and doesn't that call suspend_common(), and doesn't that call hcd->driver->pci_suspend(), and isn't that routine ohci_suspend()? Alan Stern