On 3/24/21 4:32 PM, Shuah Khan wrote:

On 3/23/21 6:02 PM, Randy Dunlap wrote:

quoted

In list.h, the kernel-doc for list_del() should be immediately
preceding the implementation and not separated from it by
another function implementation.

Eliminates this kernel-doc error:
list.h:1: warning: 'list_del' not found

Signed-off-by: Randy Dunlap <redacted>
Cc: Valentina Manea <valentina.manea.m@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
---
  tools/usb/usbip/libsrc/list.h |   10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

--- linux-next-20210323.orig/tools/usb/usbip/libsrc/list.h
+++ linux-next-20210323/tools/usb/usbip/libsrc/list.h

@@ -77,17 +77,17 @@ static inline void __list_del(struct lis

  #define LIST_POISON1  ((void *) 0x00100100 + POISON_POINTER_DELTA)
  #define LIST_POISON2  ((void *) 0x00200200 + POISON_POINTER_DELTA)
  +static inline void __list_del_entry(struct list_head *entry)
+{
+    __list_del(entry->prev, entry->next);
+}
+
  /**
   * list_del - deletes entry from list.
   * @entry: the element to delete from the list.
   * Note: list_empty() on entry does not return true after this, the entry is
   * in an undefined state.
   */
-static inline void __list_del_entry(struct list_head *entry)
-{
-    __list_del(entry->prev, entry->next);
-}
-
  static inline void list_del(struct list_head *entry)
  {
      __list_del(entry->prev, entry->next);

Thank you for fixing this.

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

Thanks. Who do you think should merge this patch?

-- 
~Randy