On Mon, Mar 22, 2021 at 01:02:04PM +0200, Eli Billauer wrote:

On 21/03/21 14:24, Greg KH wrote:

quoted

quoted

+config XILLYBUS_CLASS

quoted

 +	tristate
 +
   config XILLYBUS
   	tristate "Xillybus generic FPGA interface"
   	depends on PCI || OF
   	select CRC32
 +	select XILLYBUS_CLASS

depends on, do not select.

XILLYBUS and XILLYBUS_PCIE are currently enabled as M in several Linux
distributions. Making them depend on, rather than select XILLYBUS_CLASS is
likely to disable the driver in those distributions.

That's not an issue here, depends-on will allow those distros to also
enable this option.

But wait, why is this a separate option at all?  Shouldn't the class
code just be part of the "core" XILLYBUS code anyway?

thanks,

greg k-h