Thread (4 messages) 4 messages, 3 authors, 2021-03-30

RE: [PATCH] usb: cdns3: delete repeated clear operations

From: Pawel Laszczak <pawell@cadence.com>
Date: 2021-03-22 07:20:34
Also in: lkml

Hi Peter,

Can you add this patch to for-usb-next branch.

Thanks.

dma_alloc_coherent already zeroes out memory, so memset is not needed.

Signed-off-by: Wang Qing <redacted>
Reviewed-by: Pawel Laszczak <pawell@cadence.com>
quoted hunk ↗ jump to hunk
---
drivers/usb/cdns3/cdnsp-mem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/cdns3/cdnsp-mem.c b/drivers/usb/cdns3/cdnsp-mem.c
index 7a84e92..1d1b9a4
--- a/drivers/usb/cdns3/cdnsp-mem.c
+++ b/drivers/usb/cdns3/cdnsp-mem.c
@@ -1231,7 +1231,6 @@ int cdnsp_mem_init(struct cdnsp_device *pdev)
	if (!pdev->dcbaa)
		return -ENOMEM;

-	memset(pdev->dcbaa, 0, sizeof(*pdev->dcbaa));
	pdev->dcbaa->dma = dma;

	cdnsp_write_64(dma, &pdev->op_regs->dcbaa_ptr);
--
2.7.4
Regards,
Pawel Laszczak
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help