Re: [PATCH 2/2] usb: webcam: Invalid size of Processing Unit Descriptor
From: Peter Chen <peter.chen@kernel.org>
Date: 2021-03-14 01:47:34
Also in:
linux-api, lkml
On 21-03-08 11:27:35, Pawel Laszczak wrote:
From: Pawel Laszczak <pawell@cadence.com> According with USB Device Class Definition for Video Device the Processing Unit Descriptor bLength should be 12 (10 + bmControlSize), but it has 11.
Does the reason forget filling bmVideoStandards entry? Peter
quoted hunk ↗ jump to hunk
Invalid length caused that Processing Unit Descriptor Test Video form CV tool failed. To fix this issue patch adds bmVideoStandards into uvc_processing_unit_descriptor structure. Signed-off-by: Pawel Laszczak <pawell@cadence.com> --- include/uapi/linux/usb/video.h | 1 + 1 file changed, 1 insertion(+)diff --git a/include/uapi/linux/usb/video.h b/include/uapi/linux/usb/video.h index d854cb19c42c..2a54e8fdd341 100644 --- a/include/uapi/linux/usb/video.h +++ b/include/uapi/linux/usb/video.h@@ -302,6 +302,7 @@ struct uvc_processing_unit_descriptor { __u8 bControlSize; __u8 bmControls[2]; __u8 iProcessing; + __u8 bmVideoStandards; } __attribute__((__packed__)); #define UVC_DT_PROCESSING_UNIT_SIZE(n) (9+(n))-- 2.25.1
-- Thanks, Peter Chen