On 2/10/21 11:16 AM, Tetsuo Handa wrote:

On 2021/02/11 3:11, Shuah Khan wrote:

quoted

I would like to see to see a complete fix. This patch changes
kthread_get_run() to return NULL. Without adding handling for
NULL in the callers of kthread_get_run(), we will start seeing
problems.

What problems are you aware of?

The fact that driver doesn't cleanup after failing to create
the thread is a problem.

quoted

Does this patch fix the problem syzbot found?

Yes, this patch as-is avoids the crash syzbot found.

Good to know. Please add handling for kthread_get_run() return
in the places I suggested in you next version of this patch.

thanks,
-- Shuah