Thread (22 messages) 22 messages, 4 authors, 2021-02-12

Re: [PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names

From: Rob Herring <robh+dt@kernel.org>
Date: 2021-02-10 18:28:46
Also in: linux-arm-msm, lkml

On Wed, Feb 10, 2021 at 11:29 AM Serge Semin
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
In accordance with the USB HCD/DRD schema all the USB controllers are
supposed to have DT-nodes named with prefix "^usb(@.*)?".  Since the
existing DT-nodes will be renamed in a subsequent patch let's first make
sure the DWC3 Qualcomm driver supports them and second falls back to the
deprecated naming so not to fail on the legacy DTS-files passed to the
newer kernels.

Signed-off-by: Serge Semin <redacted>
Reviewed-by: Bjorn Andersson <redacted>
---
 drivers/usb/dwc3/dwc3-qcom.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
index c703d552bbcf..49ad8d507d37 100644
--- a/drivers/usb/dwc3/dwc3-qcom.c
+++ b/drivers/usb/dwc3/dwc3-qcom.c
@@ -630,7 +630,8 @@ static int dwc3_qcom_of_register_core(struct platform_device *pdev)
        struct device           *dev = &pdev->dev;
        int                     ret;

-       dwc3_np = of_get_child_by_name(np, "dwc3");
+       dwc3_np = of_get_child_by_name(np, "usb") ?:
+                 of_get_child_by_name(np, "dwc3");
Is there some reason using compatible instead wouldn't work here?

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help