Re: [PATCH 2/2] usb: misc: usb5744: Add support for USB hub controller
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-02-10 02:53:49
Also in:
linux-arm-kernel, lkml
On Tue, Feb 09, 2021 at 10:53:20AM +0100, Michal Simek wrote:
+static int usb5744_i2c_probe(struct i2c_client *client,
+ const struct i2c_device_id *id)
+{
+ struct device *dev = &client->dev;
+ int ret;
+
+ /* Trigger gpio reset to the hub. */
+ ret = usb5744_init_hw(dev);
+ if (ret)
+ return ret;
+
+ /* Send SMBus command to boot hub. */
+ ret = i2c_smbus_write_word_data(client, 0xAA, swab16(0x5600));
Hi Michal
This is not my area of the kernel. But that swab16() stood out, and
made me wonder about endianness. Will this work correctly on big and
little endian hosts?
Andrew