Re: [PATCH v6 09/11] usb: dwc3: gadget: Implement setting of SSP rate
From: Felipe Balbi <balbi@kernel.org>
Date: 2021-01-14 10:03:25
Hi, Thinh Nguyen [off-list ref] writes:
quoted hunk ↗ jump to hunk
@@ -2476,6 +2506,17 @@ static void dwc3_gadget_set_speed(struct usb_gadget *g, spin_unlock_irqrestore(&dwc->lock, flags); } +static void dwc3_gadget_set_ssp_rate(struct usb_gadget *g, + enum usb_ssp_rate rate) +{ + struct dwc3 *dwc = gadget_to_dwc(g); + unsigned long flags; + + spin_lock_irqsave(&dwc->lock, flags); + dwc->gadget_ssp_rate = rate; + spin_unlock_irqrestore(&dwc->lock, flags); +}
it would be best to make this return a value. If udc_set_ssp_rate() is called with invalid rate, UDC can notify core. -- balbi
Attachments
- signature.asc [application/pgp-signature] 857 bytes