Thread (7 messages) 7 messages, 4 authors, 2021-01-27

Re: [PATCH v6] usb: xhci-mtk: fix unreleased bandwidth data

From: Chunfeng Yun <chunfeng.yun@mediatek.com>
Date: 2021-01-27 06:31:36
Also in: linux-arm-kernel, linux-mediatek, lkml

On Tue, 2021-01-26 at 16:27 +0200, Mathias Nyman wrote:
On 26.1.2021 16.13, Greg Kroah-Hartman wrote:
quoted
On Wed, Jan 13, 2021 at 06:05:11PM +0800, Ikjoon Jang wrote:
quoted
xhci-mtk needs XHCI_MTK_HOST quirk functions in add_endpoint() and
drop_endpoint() to handle its own sw bandwidth management.

It stores bandwidth data into an internal table every time
add_endpoint() is called, and drops those in drop_endpoint().
But when bandwidth allocation fails at one endpoint, all earlier
allocation from the same interface could still remain at the table.

This patch moves bandwidth management codes to check_bandwidth() and
reset_bandwidth() path. To do so, this patch also adds those functions
to xhci_driver_overrides and lets mtk-xhci to release all failed
endpoints in reset_bandwidth() path.

Fixes: 08e469de87a2 ("usb: xhci-mtk: supports bandwidth scheduling with multi-TT")
Signed-off-by: Ikjoon Jang <redacted>
Mathias, any objection to me taking this patch, or do you have others
being queued up for 5.11-final?
No objections, haven't tried it out but it looks good to me.

If I finish some additional small fix for 5.11-final I can make it on top of this
Please give me some time to test this patch, thank you
-Mathias 
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help