Thread (2 messages) 2 messages, 2 authors, 2021-01-15

Re: [PATCH -next] usb: usbip: Use DEFINE_SPINLOCK() for spinlock

From: Shuah Khan <skhan@linuxfoundation.org>
Date: 2021-01-15 17:58:07
Also in: lkml

On 12/23/20 7:14 AM, Zheng Yongjun wrote:
quoted hunk ↗ jump to hunk
spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Signed-off-by: Zheng Yongjun <redacted>
---
  drivers/usb/usbip/stub_main.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/usbip/stub_main.c b/drivers/usb/usbip/stub_main.c
index c1c0bbc9f8b1..77a5b3f8736a 100644
--- a/drivers/usb/usbip/stub_main.c
+++ b/drivers/usb/usbip/stub_main.c
@@ -23,7 +23,7 @@ struct kmem_cache *stub_priv_cache;
   */
  #define MAX_BUSID 16
  static struct bus_id_priv busid_table[MAX_BUSID];
-static spinlock_t busid_table_lock;
+static DEFINE_SPINLOCK(busid_table_lock);
  
  static void init_busid_table(void)
  {
@@ -35,8 +35,6 @@ static void init_busid_table(void)
  	 */
  	memset(busid_table, 0, sizeof(busid_table));
  
-	spin_lock_init(&busid_table_lock);
-
  	for (i = 0; i < MAX_BUSID; i++)
  		spin_lock_init(&busid_table[i].busid_lock);
  }

Sorry for the delay on this.

Looks good to me.

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help