Re: [PATCH v2 5/5] usb: gadget: u_audio: clean up locking
From: Felipe Balbi <balbi@kernel.org>
Date: 2021-01-07 09:29:34
Also in:
lkml
Attachments
- signature.asc [application/pgp-signature] 857 bytes
From: Felipe Balbi <balbi@kernel.org>
Date: 2021-01-07 09:29:34
Also in:
lkml
Jerome Brunet [off-list ref] writes:
snd_pcm_stream_lock() is held when the ALSA .trigger() callback is called. The lock of 'struct uac_rtd_params' is not necessary since all its locking operation are done under the snd_pcm_stream_lock() too. Also, usb_request .complete() is called with irqs disabled, so saving and restoring the irqs is not necessary. Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
This is nice! Acked-by: Felipe Balbi <redacted> -- balbi