Re: [PATCH net-next 01/12] net: core: add function dev_fetch_sw_netstats for fetching pcpu_sw_netstats
flat view
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2020-10-11 19:54:24
Also in:
bridge, linux-rdma, linux-wireless, netdev
On Sun, 11 Oct 2020 21:36:43 +0200 Heiner Kallweit [off-list ref] wrote:
+void dev_fetch_sw_netstats(struct rtnl_link_stats64 *s, + struct pcpu_sw_netstats __percpu *netstats)
netstats is unmodified, should it be const?
quoted hunk ↗ jump to hunk
+{ + int cpu; + + if (IS_ERR_OR_NULL(netstats)) + return;
Any code calling this with a null pointer is broken/buggy, please don't
ignore that.