Thread (22 messages) 22 messages, 2 authors, 2020-09-03
STALE2136d

[PATCH 06/19] thunderbolt: No need to log an error if tb_switch_lane_bonding_enable() fails

From: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: 2020-08-19 12:03:44
Also in: linux-acpi, linux-pci
Subsystem: the rest, thunderbolt driver · Maintainers: Linus Torvalds, Andreas Noever, Mika Westerberg, Yehezkel Bernat

The function already logs an error if it fails so get rid of the
duplication.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/thunderbolt/tb.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/thunderbolt/tb.c b/drivers/thunderbolt/tb.c
index f507815040eb..98f268a818a0 100644
--- a/drivers/thunderbolt/tb.c
+++ b/drivers/thunderbolt/tb.c
@@ -592,8 +592,7 @@ static void tb_scan_port(struct tb_port *port)
 	}
 
 	/* Enable lane bonding if supported */
-	if (tb_switch_lane_bonding_enable(sw))
-		tb_sw_warn(sw, "failed to enable lane bonding\n");
+	tb_switch_lane_bonding_enable(sw);
 
 	if (tb_enable_tmu(sw))
 		tb_sw_warn(sw, "failed to enable TMU\n");
@@ -1245,8 +1244,7 @@ static void tb_restore_children(struct tb_switch *sw)
 		if (!tb_port_has_remote(port))
 			continue;
 
-		if (tb_switch_lane_bonding_enable(port->remote->sw))
-			dev_warn(&sw->dev, "failed to restore lane bonding\n");
+		tb_switch_lane_bonding_enable(port->remote->sw);
 
 		tb_restore_children(port->remote->sw);
 	}
-- 
2.28.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help