Re: [PATCH 3/3] usb: Add Kconfig and Makefile changes to build brcmstb-usb-pinmap
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2020-08-13 05:40:57
Also in:
linux-arm-kernel, linux-devicetree, lkml
On Wed, Aug 12, 2020 at 04:20:18PM -0400, Al Cooper wrote:
From: Al Cooper <redacted> Add Kconfig and Makefile changes to build brcmstb-usb-pinmap and update MAINTAINERS for the new driver.
This can be part of the previous patch, or at least the Kconfig and Makefile changes should be there so that we build the code when we add it.
refs #SWLINUX-5537
What is this?
quoted hunk ↗ jump to hunk
Signed-off-by: Al Cooper <redacted> --- MAINTAINERS | 8 ++++++++ drivers/usb/host/Kconfig | 4 ++++ drivers/usb/host/Makefile | 1 + 3 files changed, 13 insertions(+)diff --git a/MAINTAINERS b/MAINTAINERS index f0569cf304ca..3a44ac61899b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS@@ -3527,6 +3527,14 @@ S: Maintained F: Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml F: drivers/usb/host/ehci-brcm.* +BROADCOM BRCMSTB USB PIN MAP DRIVER +M: Al Cooper <alcooperx@gmail.com> +L: linux-usb@vger.kernel.org +L: bcm-kernel-feedback-list@broadcom.com +S: Maintained +F: Documentation/devicetree/bindings/usb/brcm,usb-pinmap.yaml +F: drivers/usb/host/brcmstb-usb-pinmap.c + BROADCOM BRCMSTB USB2 and USB3 PHY DRIVER M: Al Cooper <alcooperx@gmail.com> L: linux-kernel@vger.kernel.orgdiff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 1cb3004ea7b2..9c285053bb0c 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig@@ -109,12 +109,16 @@ endif # USB_XHCI_HCD config USB_EHCI_BRCMSTB tristate +config BRCM_USB_PINMAP + tristate + config USB_BRCMSTB tristate "Broadcom STB USB support" depends on (ARCH_BRCMSTB && PHY_BRCM_USB) || COMPILE_TEST select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD select USB_EHCI_BRCMSTB if USB_EHCI_HCD select USB_XHCI_PLATFORM if USB_XHCI_HCD + select BRCM_USB_PINMAP help Enables support for XHCI, EHCI and OHCI host controllers found in Broadcom STB SoC's.diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile index bc731332fed9..0e63ef94790d 100644 --- a/drivers/usb/host/Makefile +++ b/drivers/usb/host/Makefile@@ -90,3 +90,4 @@ obj-$(CONFIG_USB_HCD_BCMA) += bcma-hcd.o obj-$(CONFIG_USB_HCD_SSB) += ssb-hcd.o obj-$(CONFIG_USB_FOTG210_HCD) += fotg210-hcd.o obj-$(CONFIG_USB_MAX3421_HCD) += max3421-hcd.o +obj-$(CONFIG_BRCM_USB_PINMAP) += brcmstb-usb-pinmap.o
Shouldn't this driver be in usb/misc/ with other drivers like this? Why host? Wait, why is this a separate driver at all? Why not just build it into the USB_BRCMSTB driver? thanks, greg k-h