Thread (35 messages) 35 messages, 6 authors, 2019-08-22

Re: [PATCH v2 09/10] usb-storage: remove single-use define for debugging

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2019-08-13 13:12:53
Also in: linux-arch, linux-kbuild, linux-modules, linux-scsi, lkml

On Tue, Aug 13, 2019 at 02:42:59PM +0200, Greg KH wrote:
On Tue, Aug 13, 2019 at 01:17:06PM +0100, Matthias Maennich wrote:
quoted
USB_STORAGE was defined as "usb-storage: " and used in a single location
as argument to printk. In order to be able to use the name
'USB_STORAGE', drop the definition and use the string directly for the
printk call.

Signed-off-by: Matthias Maennich <maennich@google.com>
---
 drivers/usb/storage/debug.h    | 2 --
 drivers/usb/storage/scsiglue.c | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)
I'll go take this today.  The module really should just be using
dev_err() there.  It needs to be cleaned up :(
Now applied to the usb git tree, thanks.

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help