Thread (15 messages) 15 messages, 3 authors, 2018-10-01

usb: dwc2: Fix HiKey regression caused by power_down feature

From: John Stultz <hidden>
Date: 2018-09-25 17:59:45
Also in: lkml

On Tue, Sep 25, 2018 at 3:04 AM, Artur Petrosyan
[off-list ref] wrote:
Just a clarification by this commit "[PATCH] usb: dwc2: Fix HiKey
regression caused by power_down feature"
https://marc.info/?l=linux-usb&m=152669095513248&w=2

the power_down is disabled setting "p->power_down = false;" in
"dwc2_set_his_params" function.

Could you please clarify that the testes done for those 3 patches were
done enabling "p->power_down = true;" in "dwc2_set_his_params" function.
So if I remove the "power_down = true" initialization, USB does not
seem to function.

If I boot w/ the gadget port removed, the USB host ports do work, but
plugging in the gadget cable results in a bunch of:
   dwc2 f72c0000.usb: Waiting for Host Mode, Mode=Peripheral
messages.

If I boot w/ the gadget port plugged in, USB gadget mode doesn't seem
to function at all, and when I remove the gadget cable nothing
happens, it doesn't switch to host mode.

thanks
-john
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help