On Wed, Jun 20, 2018 at 7:07 PM, Fabio Estevam [off-list ref] wrote:

This patches causes a regression on a imx51-babbage running 4.18-rc1:
I get a kernel hang.

If I revert it on top of 4.18-rc1, then it boots fine and USB host is
functional.

I understand this patch fixes a kernel hang for you, so which commit
is responsible for the hang you observe?

It seems this commit fixes a hang for you and causes another hang for me :-)

Any ideas?

I am able to boot again if I skip passing the CI_HDRC_OVERRIDE_PHY_CONTROL flag:
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c

@@ -294,7 +294,6 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
        if ((of_device_is_compatible(np, "fsl,imx53-usb") ||
             of_device_is_compatible(np, "fsl,imx51-usb")) && pdata.usb_phy &&
            of_usb_get_phy_mode(np) == USBPHY_INTERFACE_MODE_ULPI) {
-               pdata.flags |= CI_HDRC_OVERRIDE_PHY_CONTROL;
                data->override_phy_control = true;
                usb_phy_init(pdata.usb_phy);
        }