On 2018/6/1 2:59, Andy Shevchenko wrote:

On Thu, May 31, 2018 at 9:56 PM, Sergei Shtylyov
[off-list ref] wrote:

quoted

On 05/31/2018 09:47 PM, Andy Shevchenko wrote:

quoted

quoted

quoted

quoted

-     int err, i;

quoted

quoted

quoted

quoted

+     err = match_string(usbphy_modes, ARRAY_SIZE(usbphy_modes), phy_type);
+     if (err < 0)

   This is one of the few cases when 'err' is not the best name for such a
variable. I'd prefer to see something like 'match' or even 'rc' or 'ret'... :-)

Then leaving i would make it?

   Yes. :-)

So, I leave it to Greg to decide either it's okay in this version, or
needs update with i left untouched.

Hi Greg,

IIRC, you seems want to keep the err unchanged, right?

Please let me know if another version is need.

Thanks
Yisheng

quoted

quoted

I'm okay with either which just not renames err, b/c it's used with
something else in this function.

   Looking at it again, 'err' seems equally bad for the result of
of_property_read_string()... unless the check there is changed to just *if* (err) --
this function never returns positive values, 0 means success, others mean error.

While you seems right, this is matter of another change which you are
welcome to propose.

---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html