Re: [PATCH v3 10/13] tracing/probes: Allow symstr type for function entry arguments in return probes

From
Masami Hiramatsu (Google) <mhiramat@kernel.org>
Date
2026-11-13 13:15:30
Reply to
sashiko-bot@kernel.org, 2026-11-13
On Fri, 13 Nov 2026 08:39:42 +0000, sashiko-bot@kernel.org [off-list ref] wrote:
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] tracing/probes: missing Fixes trailer for FETCH_OP_EDATA symstr
  fix
Note that this is not a fix, but extending ability.
Let me pick this to probes/core (and then for-next)

Thank you,
--

commit 48b9066b7edfcc25acab7912c4c55cf34cf5c88d
Author: Masami Hiramatsu (Google) [off-list ref]
quoted
tracing/probes: Allow symstr type for function entry arguments in return probes

Function entry arguments accessed in return probes ($argN or BTF entry
arguments) are fetched from the entry data buffer via FETCH_OP_EDATA,
which was omitted from the allowed operations for the "symstr" type and
rejected with BAD_SYMSTRING.

Allow FETCH_OP_EDATA to be formatted as "symstr".

Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
[Severity: Low]
FETCH_OP_EDATA was introduced after the symstr type check in
finalize_fetch_insn() already existed.  Should this include:

  Fixes: 25f00e40ce79 ("tracing/probes: Support $argN in return probe (kprobe and fprobe)")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/179455847934.403392.15146485751358774349.stgit@devnote2?part=10
-- 
Masami Hiramatsu (Google) [off-list ref]
Thread (16 messages) 16 messages, 2 authors, last reply 4d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help