Re: [PATCH v7 10/10] tracing/osnoise: Refuse timerlat fd open if tracer inactive

From
sashiko-bot@kernel.org
Date
2026-11-13 06:55:42
Reply to
Crystal Wood, 2026-11-13
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] tracing/osnoise: missing Fixes: trailer for timerlat_fd_open()
  fix
--

commit 2b08a7c2950ae2b8e79253b75767a234cab88c0c
Author: Crystal Wood [off-list ref]
tracing/osnoise: Refuse timerlat fd open if tracer inactive

Besides being generally bad, allowing an fd open when there are no active
instances means that osnoise_options_write() and osnoise_cpus_write() will
leave it active during reconfiguration, causing at least WARN splats.

Signed-off-by: Crystal Wood <redacted>
[Severity: Low]
This fixes a bug in timerlat_fd_open() where a user fd can be opened while
no instances are registered.  Should this include:

  Fixes: e88ed227f639 ("tracing/timerlat: Add user-space interface")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113064103.3041704-1-crwood@redhat.com?part=10
Thread (17 messages) 17 messages, 2 authors, last reply 3d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help