[PATCH v1 2/9] ring-buffer: Drop cpus_read_lock() from ring_buffer_poll_remote()

From
Vincent Donnefort <vdonnefort@google.com>
Date
2026-11-12 14:14:52
Also in
lkml
Reply to
Vincent Donnefort, 2026-11-12
ring_buffer_poll_remote() holds cpus_read_lock() while walking
buffer->cpumask. Ring buffers are never freed on CPU hotunplug, and
trace_rb_cpu_prepare() already orders buffer->buffers with the cpumask
update (with rb_cpu_sync()). Drop cpus_read_lock() as it is
unnecessary.

Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
---
 kernel/trace/ring_buffer.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index bd8126f6353b..32d3c47dbdf0 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -6918,8 +6918,6 @@ int ring_buffer_poll_remote(struct trace_buffer *buffer, int cpu)
 		return 0;
 	}
 
-	guard(cpus_read_lock)();
-
 	/*
 	 * Make sure all the ring buffers are up to date before we start reading
 	 * them.
-- 
2.56.0.567.gdb80ae8cd5-goog
Thread (13 messages) 13 messages, 2 authors, last reply 4d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help