Re: [PATCH v3 02/16] tracing/filters: Fix MATCH_END_ONLY regex matching for fixed-size strings

From
Masami Hiramatsu (Google) <mhiramat@kernel.org>
Date
2026-10-28 01:14:06
Also in
linux-kselftest, lkml
Reply to
Masami Hiramatsu (Google), 2026-10-28
On Wed, 28 Oct 2026 09:43:43 +0900, Masami Hiramatsu (Google) [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -1087,6 +1087,20 @@ static int regex_match_end(char *str, struct regex *r, int len)
+{
+	int slen;
+
+	if (len < r->len)
BTW, this is required for skipping strnlen().
quoted hunk ↗ jump to hunk
+		return 0;
+
+	slen = strnlen(str, len);
+	if (slen >= r->len &&
And this also checks actual length.
quoted hunk ↗ jump to hunk
+	    memcmp(str + slen - r->len, r->pattern, r->len) == 0)
+		return 1;
+	return 0;
Thanks,

-- 
Masami Hiramatsu (Google) [off-list ref]
Thread (30 messages) 30 messages, 3 authors, last reply 14d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help