Re: [PATCH] selftests/ftrace: Add missing spaces after ! in probe syntax tests

From
Masami Hiramatsu (Google) <mhiramat@kernel.org>
Date
2026-10-26 14:09:02
Also in
linux-kselftest, lkml
Reply to
Jaewon Jung, 2026-10-25
On Sun, 25 Oct 2026 16:50:42 +0900, Jaewon Jung [off-list ref] wrote:
Add the missing space between ! and grep. Otherwise, the shell tries
to run !grep and reports "!grep: not found". This always skips the
conditional checks without checking for kernel return probe argument
support.

Signed-off-by: Jaewon Jung <redacted>
Looks good to me! Also we need followings.

Fixes: 25f00e40ce79 ("tracing/probes: Support $argN in return probe (kprobe and fprobe)")
Cc: <redacted>

Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Shuah, can you pick this fix?

Thanks,

-- 
Masami Hiramatsu (Google) [off-list ref]
Thread (5 messages) 5 messages, 3 authors, last reply 14d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help