Thread (15 messages) 15 messages, 2 authors, 1d ago

Re: [PATCH v4 3/9] mm/vmscan: move struct scan_control to a dedicated header

flat view

From: Barry Song <baohua@kernel.org>
Date: 2026-10-24 22:27:48
Also in: bpf, cgroups, linux-mm, lkml

On Mon, Oct 19, 2026 at 11:53 AM Ridong Chen [off-list ref] wrote:
From: Ridong Chen <redacted>

The definition of struct scan_control has lived inline at the top of
mm/vmscan.c. Move it out to a new mm/vmscan.h so the reclaim-internal
state can be referenced from other reclaim translation units without
duplicating the definition.

The header uses an ordinary include guard and pulls in only what the
struct needs (nodemask_t, gfp_t and struct reclaim_state).

mm/trace_vmscan.h includes the new header directly so that any
translation unit pulling in the trace events (mm/vmscan.c, mm/shrinker.c)
sees the full definition of struct scan_control regardless of include
order.

No functional change.

Assisted-by: LLM
Signed-off-by: Ridong Chen <redacted>
---
Well, vmscan.c is way too long, so moving some common
code out of it seems like a good idea, beyond just serving
the needs of tracepoints. We may move more code out of it
in the future.

Best Regards
Barry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help