Re: [PATCH bpf-next v2 19/21] selftests/bpf: Add tracing_multi bpf prog link info test
flat view
From: bot+bpf-ci@kernel.org
Date: 2026-10-12 16:11:58
Also in:
bpf, linux-kselftest, lkml
selftests/bpf: Add tracing_multi bpf prog link info test
TL;DR: Nit only: the new <linux/kallsyms.h> include in fill_link_info.c may be unnecessary, since trace_helpers.h already seems to provide the ksym helpers the test uses.
quoted hunk ↗ jump to hunk
diff --git a/tools/testing/selftests/bpf/prog_tests/fill_link_info.c b/tools/testing/selftests/bpf/prog_tests/fill_link_info.c index 0918321c8e63..422e94f13409 100644 --- a/tools/testing/selftests/bpf/prog_tests/fill_link_info.c +++ b/tools/testing/selftests/bpf/prog_tests/fill_link_info.c@@ -3,11 +3,13 @@ #include <string.h> #include <linux/bpf.h> +#include <linux/kallsyms.h> #include <linux/limits.h> #include <bpf/btf.h> #include <test_progs.h> #include "trace_helpers.h" #include "test_fill_link_info.skel.h" +#include "tracing_multi_bpf.skel.h" #include "bpf/libbpf_internal.h"
this isn't a bug, but is <linux/kallsyms.h> needed for anything here? The ksym helpers used by this test (ksym_search(), ksym_get_addr(), struct ksym) seem to come from trace_helpers.h, which is already included, and nothing in fill_link_info.c appears to use KSYM_NAME_LEN, kallsyms_lookup() or print_ip_sym() from the tools/include/linux/kallsyms.h shim. --- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/38273555988