[PATCH v2 5/9] tracing/osnoise: start_kthread: Always check OSN_WORKLOAD
flat view
COOLING9d
SUPERSEDED
From: Crystal Wood <hidden>
Date: 2026-10-10 02:24:10
Subsystem:
the rest, tracing, tracing os noise / latency tracers · Maintainers:
Linus Torvalds, Steven Rostedt, Masami Hiramatsu
Revision v2 of 3 in this series.
Revisions (3)
- v2 current
- v3 [diff vs current]
- v4 [diff vs current]
We can get here on timerlat with OSN_WORKLOAD cleared via osnoise_hotplug_workfn(). While we're moving this code, remove the pointless compiler barrier immediately before returning from a function. Even if it's inlined, it's not doing anything useful. Signed-off-by: Crystal Wood <redacted> --- v2: no change --- kernel/trace/trace_osnoise.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c
index 51e9b8837d20..92b1216d5740 100644
--- a/kernel/trace/trace_osnoise.c
+++ b/kernel/trace/trace_osnoise.c@@ -2077,16 +2077,17 @@ static int start_kthread(unsigned int cpu) if (osn->kthread) goto out; + /* Can still happen with timerlat via cpu hotplug */ + if (!test_bit(OSN_WORKLOAD, &osnoise_options)) { + if (!timerlat_enabled()) + osn->sampling = true; + goto out; + } + if (timerlat_enabled()) { snprintf(comm, 24, "timerlat/%d", cpu); main = timerlat_main; } else { - /* if no workload, just return */ - if (!test_bit(OSN_WORKLOAD, &osnoise_options)) { - cpu_osn_var(cpu)->sampling = true; - barrier(); - goto out; - } snprintf(comm, 24, "osnoise/%d", cpu); }
--
2.54.0