Thread (12 messages) 12 messages, 3 authors, 21d ago

Re: [PATCH RFC v2 1/7] mm/memcontrol: drop unused vmscan tracepoint include

flat view

From: Muchun Song <muchun.song@linux.dev>
Date: 2026-09-28 12:08:39
Also in: cgroups, linux-mm, lkml

On Sep 28, 2026, at 19:46, Ridong Chen [off-list ref] wrote:

From: Ridong Chen <redacted>

memcontrol.c includes <trace/events/vmscan.h> but does not use any of
the tracepoints or macros it defines: all tracepoints invoked here come
from memcg.h and writeback.h.  Removing the include still compiles
cleanly.

Assisted-by: Claude:claude-opus-4-8
Since commit 816d9992d9ed, the label we recommend is Assisted-by: LLM.
quoted hunk ↗ jump to hunk
Signed-off-by: Ridong Chen <redacted>
---
mm/memcontrol.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index aad0498a7bd6..95c2322d4a6f 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -77,8 +77,6 @@
#include <trace/events/memcg.h>
#undef CREATE_TRACE_POINTS

-#include <trace/events/vmscan.h>
-
struct cgroup_subsys memory_cgrp_subsys __read_mostly;
EXPORT_SYMBOL(memory_cgrp_subsys);
Acked-by: Muchun Song <muchun.song@linux.dev>

Thanks.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help