Re: [PATCH RFC v3 01/13] entry: Pass pt_regs to irqentry_exit_cond_resched()
flat view
From: bot+bpf-ci@kernel.org
Date: 2026-09-15 14:17:48
Also in:
bpf, lkml, rcu, xen-devel
quoted hunk ↗ jump to hunk
diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 2c64b388f6164..3d85035f5624f 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c
[ ... ]
quoted hunk ↗ jump to hunk
diff --git a/include/linux/irq-entry-common.h b/include/linux/irq-entry-common.h index 0bb6c03481fad..b811b469b0a77 100644 --- a/include/linux/irq-entry-common.h +++ b/include/linux/irq-entry-common.h@@ -346,21 +346,21 @@ typedef struct irqentry_state { * * Conditional reschedule with additional sanity checks. */ -void raw_irqentry_exit_cond_resched(void); +void raw_irqentry_exit_cond_resched(struct pt_regs *regs);
Should the kernel-doc block above this declaration be updated with an @regs parameter description? Every other function in this header that takes a regs argument documents it (for example, irqentry_enter_from_ kernel_mode's block has "* @regs: Pointer to currents pt_regs"). Also, the kernel-doc block documents "irqentry_exit_cond_resched" but the prototype is "raw_irqentry_exit_cond_resched" - that mismatch currently prevents kernel-doc from checking the parameter list, so adding @regs wouldn't trigger a warning yet, but it would make the documentation complete for readers of the header. [ ... ]
quoted hunk ↗ jump to hunk
diff --git a/kernel/entry/common.c b/kernel/entry/common.c index e3d381fd3d251..e4acd50bd81a1 100644 --- a/kernel/entry/common.c +++ b/kernel/entry/common.c
[ ... ] --- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/34975311706