Thread (5 messages) flat view 5 messages, 4 authors, 11d ago

Re: [PATCH v1] ring-buffer: Clean up resize_disabled checks

From: David CARLIER <hidden>
Date: 2026-09-14 19:09:38
Also in: lkml

Hi Vincent.
+   if (rb_resize_disabled(buffer, cpu_id)) {
+           err = -EBUSY;
+           goto out_err_unlock;
+   }
For a single CPU, this now happens before the nr_pages == cpu_buffer->nr_pages
early exit, so writing the same size to per_cpu/cpuN/buffer_size_kb on a
mapped or persistent instance CPU fails with EBUSY instead of succeeding.
Intended ?
Additionally, remove the unnecessary cpumask_test_cpu in
ring_buffer_subbuf_order_set().
The install loop still has one.

Otherwise removing the second check is fine, the hotplug window is
covered by the cpus_read_lock() patch I sent separately.

Cheers.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help