Re: [PATCH v4 16/16] mm/page-flags: remove PG_private
From: "David Hildenbrand (Arm)" <david@kernel.org>
Date: 2026-09-14 13:37:51
Also in:
kexec, linux-doc, linux-fsdevel, linux-mm, lkml, sashiko-reviews
On 9/14/26 04:47, sashiko-bot@kernel.org wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] Silent memory leak of folio private data due to missing check for leaked `folio->private` data when a head page is freed. -- commit ebe4dd474a496c46897e3f790e03a43cc0508eaf Author: Zi Yan [off-list ref] mm/page-flags: remove PG_private folio->private != NULL indicates a folio carries private data, replacing PG_private. All PG_private users are converted. Remove PG_private and reserve the space as PG_folio for future use. Unused PG_private functions are removed too.quoted
diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index 08988877331ba..10f4ad075ea48 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h[ ... ]quoted
@@ -105,7 +101,7 @@ enum pageflags { PG_owner_2, /* Owner use. If pagecache, fs may use */ PG_arch_1, PG_reserved, - PG_private, /* If pagecache, has fs-private data */ + PG_folio, /* Do not use: reserved for folio identification */[Severity: High]
"High" lol -- Cheers, David