Thread (9 messages) flat view 9 messages, 2 authors, 3d ago

Re: [PATCH v5 1/5] rv/reactors: use LD_WAIT_SPIN as the reactor lockdep wait type

From: sashiko-bot@kernel.org
Date: 2026-09-06 17:18:02

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message claims to add documentation, but the patch does not modify any documentation files.
--

commit 9f88f295cb2517cf173e24803d40575bacb352d6
Author: Wen Yang [off-list ref]

rv/reactors: use LD_WAIT_SPIN as the reactor lockdep wait type

This patch changes the reactor lockdep wait type override from LD_WAIT_FREE
to LD_WAIT_SPIN to prevent false-positive "Invalid wait context" warnings.
This resolves issues when preempting code, like the scheduler, takes spinlocks
while a reactor callback is running.
Use LD_WAIT_SPIN instead of LD_WAIT_FREE, which causes false-positive
warnings in preemptible contexts due to scheduler preemption taking
rq->__lock. Add documentation to runtime-verification.rst.
[Severity: Low]
The commit message explicitly claims to add documentation to
runtime-verification.rst to describe the LD_WAIT_SPIN logic change made in
rv_react() (kernel/trace/rv/rv_reactors.c). 

However, looking at the patch, no documentation files are actually modified.

Was the documentation update for this change accidentally dropped from the
commit?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1788705281.git.wen.yang@linux.dev?part=1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help