Re: [PATCH v2 1/3] dmaengine: vchan: add vchan_chan_name() to get channel device name
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2026-09-04 09:08:29
Also in:
dmaengine, imx, linux-arm-kernel, linux-mips, linux-sunxi, linux-tegra, lkml
On Thu, Sep 03, 2026 at 04:53:11PM -0400, Frank.Li@oss.nxp.com wrote:
Introduce vchan_chan_name() to obtain the DMA channel device name. Use a dedicated helper instead of directly accessing dma_chan::dev so callers remain unaffected by an upcoming rename of the struct member.
LGTM, Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> ...
ret = devm_request_irq(&pdev->dev, chan->irq,
stm32_dma_chan_irq, 0,
- dev_name(chan2dev(chan)), chan);
+ vchan_chan_name(&chan->vchan), chan);
if (ret) {
dev_err(&pdev->dev,
"request_irq failed with err %d channel %d\n",This one...
quoted hunk ↗ jump to hunk
+++ b/drivers/dma/stm32/stm32-dma3.c
ret = devm_request_irq(&pdev->dev, chan->irq, stm32_dma3_chan_irq, 0,
- dev_name(chan2dev(chan)), chan);
+ vchan_chan_name(&chan->vchan), chan);
if (ret) {
dev_err_probe(&pdev->dev, ret, "Failed to request channel %s IRQ\n",
- dev_name(chan2dev(chan)));
+ vchan_chan_name(&chan->vchan));
goto err_clk_disable;...and this one are duplicate messages as devm_request*irq() printsr most of the information. Not sure if there will be a patch to simply drop them. -- With Best Regards, Andy Shevchenko