Re: [PATCH v13 05/12] tracing/wprobe: Add wprobe (watchpoint probe) trace event support
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Date: 2026-08-30 05:35:24
Also in:
linux-perf-users, sashiko-reviews
On Sat, 22 Aug 2026 09:49:13 +0000 sashiko-bot@kernel.org wrote:
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [High] The trace_wprobe_show function uses %pS to format the symbol address, breaking dynamic event restoration because kstrtoint() in parse_address_spec cannot parse the appended symbol size.
Oops, it is my fault. Let me fix it.
- [Medium] Address validation in parse_address_spec incorrectly exempts address 0 from the kernel space TASK_SIZE check, allowing user-space tracing at address 0.
Ah, address 0 will hit in the userspace. OK, that should be fixed. -- Masami Hiramatsu (Google) [off-list ref]