Thread (15 messages) flat view 15 messages, 3 authors, 22d ago

Re: [PATCH v2] tracing/user_events: Clear copied tracing state before fork duplication

From: Bradley Morgan <hidden>
Date: 2026-08-27 12:09:57
Also in: lkml, stable

On 27 August 2026 13:08:39 BST, Steven Rostedt [off-list ref] wrote:
On Wed, 26 Aug 2026 21:44:15 +0000
Jérémy Jean [off-list ref] wrote:
quoted
diff --git a/kernel/trace/trace_events_user.c
b/kernel/trace/trace_events_user.c
quoted
index 2bbc89d4a266..339e18085af3 100644
--- a/kernel/trace/trace_events_user.c
+++ b/kernel/trace/trace_events_user.c
@@ -865,9 +865,12 @@ void user_event_mm_remove(struct task_struct *t)
 
 void user_event_mm_dup(struct task_struct *t, struct user_event_mm
*old_mm)
quoted
 {
-	struct user_event_mm *mm = user_event_mm_alloc(t);
+	struct user_event_mm *mm;
Why this change?
quoted
 	struct user_event_enabler *enabler;
 
+	t->user_event_mm = NULL;
+	mm = user_event_mm_alloc(t);
I don't see why you moved the mm assignment down here. The
t->user_event_mm
is not used in user_event_mm_alloc().
Uff, not wrong, I must be dummy dumb dumb, well, I base my reviews off 

Does this fix the bug? And is this a small fix?

-- Steve
quoted
+
 	if (!mm)
 		return;
 
--- Thanks!
https://lore.kernel.org/all/EE579805-42F2-4C58-B752-F28779EEB717@grrlz.net/ (local)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help