Re: [RFC PATCH 03/57] mm/collapse: add collapse.h for the shared collapse state
From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Date: 2026-08-24 15:51:42
Also in:
bpf, linux-kselftest, linux-mm, lkml
On Mon, Aug 24, 2026 at 04:18:09PM +0100, Kiryl Shutsemau wrote:
On Mon, Aug 24, 2026 at 03:09:00PM +0100, Lorenzo Stoakes (ARM) wrote:quoted
On Mon, Aug 24, 2026 at 01:36:03PM +0100, Kiryl Shutsemau wrote:quoted
On Mon, Aug 24, 2026 at 02:28:39PM +0200, David Hildenbrand (Arm) wrote:quoted
On 8/24/26 14:10, Kiryl Shutsemau wrote:quoted
On Mon, Aug 24, 2026 at 01:47:54PM +0200, David Hildenbrand (Arm) wrote:quoted
On 8/20/26 13:11, Kiryl Shutsemau wrote:quoted
I went for a clean collapse.c on purpose: the engine is new code, and a new file keeps it readable while both mechanisms are in the tree, with 28 as a plain delete from khugepaged.c. Your shape is less churn, though, and it keeps blame: 29-35 move about 1700 lines as add-and-delete today, and most of that would stay put, with only the daemon -- mm_slot, the scan loop, sysfs -- extracted into a new khugepaged.c. If you prefer it that way, I can give it a try for v2.Please don't respin this as a 57 patch series.I didn't plan to. The goal of this RFC was to show the final form I want to reach. I will move cleanups and refactoring to the front of the patchset and submit in small self-contained chunks while keeping the rest working in a private branch.
Sorry missed this bit - great, that works for me obviously! -- Cheers, Lorenzo