Re: [PATCH] verification/rvgen: Use .old instead of .bak for kunit backup files
flat view
From: sashiko-bot@kernel.org
Date: 2026-08-24 08:28:01
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The `rvgen kunit` tool generates `.old` backup files which are not cleaned up by `make distclean`, polluting the user's working directory. --
--- Patch [1]: [PATCH] verification/rvgen: Use .old instead of .bak for kunit backup files ---commit 293b444e4dfea5692931faee1bc9c58a549085d8 Author: Gabriele Monaco [off-list ref] verification/rvgen: Use .old instead of .bak for kunit backup files The rvgen kunit command generates .bak backup files and these can be checked in for selftests (make check). Clean targets like make disclean remove such files, leaving the tree dirty. Switch to .old to preserve a clean tree after make disclean. Closes: https://lore.kernel.org/lkml/aosuwKH5GOEo0xTN@google.com (local)
quoted hunk ↗ jump to hunk
diff --git a/tools/verification/rvgen/rvgen/kunit.py b/tools/verification/rvgen/rvgen/kunit.py index ed2082d7d3bc4..85973f918c9b5 100644 --- a/tools/verification/rvgen/rvgen/kunit.py +++ b/tools/verification/rvgen/rvgen/kunit.py
[ ... ]
quoted hunk ↗ jump to hunk
@@ -173,7 +173,7 @@ EXPORT_SYMBOL_IF_KUNIT({struct_name}); for path in (header_file_path, kunit_c_file_path): if path.exists(): try: - path.rename(path.with_suffix(path.suffix + ".bak")) + path.rename(path.with_suffix(path.suffix + ".old"))
[Severity: Medium] Will this regression leave users' working directories polluted with .old backup files that aren't cleaned up by the top-level make distclean target? The kernel's global Makefile explicitly cleans *.bak files during distclean, but ignores *.old files. When a user runs rvgen kunit in a directory with existing kunit files and accepts the backup prompt, print_files() will generate these .old files. Since they are no longer .bak files, is it expected that they will persist after running make distclean? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260824081519.81103-2-gmonaco@redhat.com?part=1