Re: [PATCH RFC 5/7] tracing: Add a test for ftrace_parse_event_string()
From: sashiko-bot@kernel.org
Date: 2026-08-13 14:14:50
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The newly added module `trace_events_test.c` lacks a `MODULE_DESCRIPTION()` declaration. Since `CONFIG_EVENT_TRACING_TEST` is a tristate config, the code can be compiled as a module. Recent Linux kernels strictly enforce module descriptions, and omitting it results in a modpost warning (`WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/trace/trace_events_test.o`). In automated CI environments that enforce zero warnings or build with `-Werror`, this will cause build failures. --
--- Patch [5]: [PATCH RFC 5/7] tracing: Add a test for ftrace_parse_event_string() ---commit 509c596a834391e59b26327382138635d44f58c9 Author: Thomas Weißschuh [off-list ref] tracing: Add a test for ftrace_parse_event_string() This commit adds a KUnit test for the ftrace_parse_event_string() function to prevent regressions as the parsing logic is updated.
quoted hunk ↗ jump to hunk
diff --git a/kernel/trace/trace_events_test.c b/kernel/trace/trace_events_test.c new file mode 100644 --- /dev/null +++ b/kernel/trace/trace_events_test.c
[ ... ]
+static struct kunit_suite trace_events_test_suite = {
+ .name = "trace-events",
+ .test_cases = trace_events_test_cases,
+};
+kunit_test_suite(trace_events_test_suite);
+
+
+MODULE_LICENSE("GPL");
+MODULE_IMPORT_NS("EXPORTED_FOR_KUNIT_TESTING");[Severity: Low] Since CONFIG_EVENT_TRACING_TEST is a tristate config and this can be compiled as a module, should a MODULE_DESCRIPTION() be added here? Recent kernels emit a modpost warning (WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/trace/trace_events_test.o) when this is omitted, which could cause build failures in automated CI environments that enforce zero warnings. -- Sashiko AI review · https://sashiko.dev/#/patchset/20260813-tracing-cli-event-filter-v1-0-57c4e8029c86@linutronix.de?part=5