Re: [PATCH v2 2/4] rv/reactors: propagate rv_register_reactor() error from reactor init
From: Gabriele Monaco <gmonaco@redhat.com>
Date: 2026-08-03 06:36:10
Also in:
lkml
On Mon, 2026-08-03 at 02:43 +0800, wen.yang@linux.dev wrote:
From: Wen Yang <redacted> Both register_react_printk() and register_react_panic() ignore the return value of rv_register_reactor() and always return 0. If the registration fails (e.g. a duplicate reactor name), the init functions silently report success even though the reactor was not registered. Propagate the error from rv_register_reactor() so a failed registration is reported instead of being silently ignored.
Reviewed-by: Gabriele Monaco <gmonaco@redhat.com>
quoted hunk ↗ jump to hunk
Suggested-by: Gabriele Monaco <gmonaco@redhat.com> Signed-off-by: Wen Yang <redacted> --- kernel/trace/rv/reactor_panic.c | 3 +-- kernel/trace/rv/reactor_printk.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)diff --git a/kernel/trace/rv/reactor_panic.c b/kernel/trace/rv/reactor_panic.c index 76537b8a4343..db7116ceafff 100644 --- a/kernel/trace/rv/reactor_panic.c +++ b/kernel/trace/rv/reactor_panic.c@@ -26,8 +26,7 @@ static struct rv_reactor rv_panic = {static int __init register_react_panic(void) { - rv_register_reactor(&rv_panic); - return 0; + return rv_register_reactor(&rv_panic); } static void __exit unregister_react_panic(void)diff --git a/kernel/trace/rv/reactor_printk.cb/kernel/trace/rv/reactor_printk.c index 48c934e315b3..002a10f6aa7b 100644--- a/kernel/trace/rv/reactor_printk.c +++ b/kernel/trace/rv/reactor_printk.c@@ -25,8 +25,7 @@ static struct rv_reactor rv_printk = {static int __init register_react_printk(void) { - rv_register_reactor(&rv_printk); - return 0; + return rv_register_reactor(&rv_printk); } static void __exit unregister_react_printk(void)