Re: [PATCH] ring-buffer: drop unneeded semicolon
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Date: 2026-08-03 05:12:48
Also in:
kernel-janitors, lkml
On Sat, 1 Aug 2026 21:09:52 +0200 Julia Lawall [off-list ref] wrote:
When a function-like macro expands to an expression, that expression
doesn't need a semicolon after it. All uses have been verified to
have their own semicolons.
This was found using the following Coccinelle semantic patch:
@r@
identifier i : script:ocaml() { String.lowercase_ascii i = i };
expression e;
@@
*#define i(...) e;
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>Looks good to me. Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
quoted hunk ↗ jump to hunk
--- kernel/trace/ring_buffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index 8e2485bb3..7749dd2ac 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c@@ -405,11 +405,11 @@ static void free_buffer_page(struct buffer_page *bpage) */ #define alloc_cpu_buffer(cpu) (struct ring_buffer_per_cpu *) \ kzalloc_node(ALIGN(sizeof(struct ring_buffer_per_cpu), \ - cache_line_size()), GFP_KERNEL, cpu_to_node(cpu)); + cache_line_size()), GFP_KERNEL, cpu_to_node(cpu)) #define alloc_cpu_page(cpu) (struct buffer_page *) \ kzalloc_node(ALIGN(sizeof(struct buffer_page), \ - cache_line_size()), GFP_KERNEL, cpu_to_node(cpu)); + cache_line_size()), GFP_KERNEL, cpu_to_node(cpu)) static struct buffer_data_page *alloc_cpu_data(int cpu, int order) {
-- Masami Hiramatsu (Google) [off-list ref]