On Sat, Jul 11, 2026 at 08:21:02AM +0530, Praveen Talari wrote:

On 11-07-2026 02:56, Mark Brown wrote:

quoted

On Sat, Jul 11, 2026 at 12:18:42AM +0530, Praveen Talari wrote:

quoted

quoted

+#include <trace/events/qcom_geni_se.h>

quoted

Should this be in rivers/soc/qcom/qcom-geni-se.c (and the first patch?)
- that way if another driver starts using them we won't multiply define
the tracepoints.

Yes, you are correct but

If this header in drivers/soc/qcom/qcom-geni-se.c, how it will be access
trace API in other drivers like i2c, spi and uart?

The header needs to be in the users but the CREATE_ define that you cut
needs to be in only one place to actually create the tracepoints.

quoted

quoted

@@ -986,10 +997,13 @@ static irqreturn_t geni_spi_isr(int irq, void *data)
  					writel(0, se->base + SE_GENI_TX_WATERMARK_REG);
  					dev_err(mas->dev, "Premature done. tx_rem = %d bpw%d\n",
  						mas->tx_rem_bytes, mas->cur_bits_per_word);
+					trace_geni_se_regs(se);

SE_GENI_TX_WATERMARK_REG is one of the registers in the tracepoint,
perhaps trace before we write to clear it?

it will be captured in m_irq register so it is not required to capture.

Are you sure that won't lead to user confusion?