Thread (5 messages) flat view 5 messages, 4 authors, 27d ago

Re: [PATCH] ufs: core: tracing: Do not dereference pointers in TP_printk()

From: "Martin K. Petersen" <martin.petersen@oracle.com>
Date: 2026-07-13 02:33:51
Also in: linux-scsi, lkml

On Tue, 30 Jun 2026 18:54:12 -0400, Steven Rostedt wrote:
The trace events in drivers/ufs/core/ufs_trace.h were converted to take a
pointer to the hba structure as an argument for the tracepoint and then in
TP_printk() the printing of the dev_name from the ring buffer was
converted to using the dev dereferenced pointer from the hba saved
pointer.

This is not allowed as the TP_printk() is executed at the time the trace
event is read from /sys/kernel/tracing/trace file. That can happen
literally, seconds, minutes, hours, weeks, days, or even months later!
There is no guarantee that the hba pointer will still exist by the time it
is dereferenced when the "trace" file is read.

[...]
Applied to 7.2/scsi-fixes, thanks!

[1/1] ufs: core: tracing: Do not dereference pointers in TP_printk()
      https://git.kernel.org/mkp/scsi/c/46aea2c64e11

-- 
Martin K. Petersen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help