Hi Mark,

On 11-07-2026 02:56, Mark Brown wrote:

On Sat, Jul 11, 2026 at 12:18:42AM +0530, Praveen Talari wrote:

quoted

The GENI SPI driver reports various transfer failures such as command
timeouts, DMA reset timeouts, DMA transaction errors, and unexpected
interrupt conditions. However, diagnosing the root cause of these
failures is difficult as the hardware state is not captured when the
error occurs.
+#include <trace/events/qcom_geni_se.h>

Should this be in rivers/soc/qcom/qcom-geni-se.c (and the first patch?)
- that way if another driver starts using them we won't multiply define
the tracepoints.

Yes, you are correct but

If this header in drivers/soc/qcom/qcom-geni-se.c, how it will be access 
trace API in other drivers like i2c, spi and uart?

quoted

@@ -986,10 +997,13 @@ static irqreturn_t geni_spi_isr(int irq, void *data)
  					writel(0, se->base + SE_GENI_TX_WATERMARK_REG);
  					dev_err(mas->dev, "Premature done. tx_rem = %d bpw%d\n",
  						mas->tx_rem_bytes, mas->cur_bits_per_word);
+					trace_geni_se_regs(se);

SE_GENI_TX_WATERMARK_REG is one of the registers in the tracepoint,
perhaps trace before we write to clear it?

it will be captured in m_irq register so it is not required to capture.

Thanks,

Praveen talari