Re: [PATCHv6 03/13] uprobes/x86: Do not leak trampoline vma mapping on optimization failure
From: Jiri Olsa <hidden>
Date: 2026-07-03 14:11:32
Also in:
bpf
On Fri, Jul 03, 2026 at 02:45:03PM +0200, Peter Zijlstra wrote:
On Fri, Jul 03, 2026 at 01:49:07PM +0200, Jiri Olsa wrote:quoted
In case the optimization fails, we leak new-ly created trampoline vma mapping (in case we just created it), let's unmap it. Fixes: ba2bfc97b462 ("uprobes/x86: Add support to optimize uprobes") Reviewed-by: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Jiri Olsa <jolsa@kernel.org>What is the intention here? That is, Patch 1 has a Fixes and is already in tip/perf/urgent (from v5), patch 2 does not have Fixes, this patch (3) has Fixes and appears to rely on patch 2. So should I stick both 2,3 into perf/urgent or what?
patch 3 fixes the vma mapping leak, and it is done on top of bigger change in patch 2 I think we are ok without patch 3 in perf/urgent, but if we want to have it there, it needs patch 2 jirka