Re: [PATCH] tracing: Cleanup event_enable_trigger_parse() by using __free()
From: Markus Elfring <hidden>
Date: 2026-07-03 05:00:28
Also in:
kernel-janitors, lkml
From: Markus Elfring <hidden>
Date: 2026-07-03 05:00:28
Also in:
kernel-janitors, lkml
quoted
…quoted
+++ b/kernel/trace/trace_events_trigger.c@@ -1739,7 +1739,7 @@ int event_enable_trigger_parse(struct event_command *cmd_ops, char *glob, char *cmd, char *param_and_filter) { struct trace_event_file *event_enable_file; - struct enable_trigger_data *enable_data; + struct enable_trigger_data *enable_data __free(kfree) = NULL;… How do you think about to reduce the scope for this local variable?No, it's fine as is.
Does this feedback mean that you disagree to an essential development requirement according to such a programming interface? https://elixir.bootlin.com/linux/v7.1.2/source/include/linux/cleanup.h#L142-L153 Regards, Markus