Re: [RFC PATCH v2 1/4] rtla/osnoise: Add IPI tracking cmdline option

On 29/06/26 12:51, Tomas Glozar wrote:

st 17. 6. 2026 v 15:18 odesílatel Valentin Schneider
[off-list ref] napsal:

quoted

@@ -305,6 +305,9 @@ static int opt_filter_cb(const struct option *opt, const char *arg, int unset)
        "the minimum delta to be considered a noise", \
        opt_llong_callback)

+#define OSNOISE_OPT_IPI OPT_BOOLEAN('i', "ipi", &params->common.ipi, \
+       "track sources of IPIs")
+

As IPI tracking is not a commonly used functionality, unlike e.g.
"-p/--period", and -i is already a different option for timerlat tools
(-i-/--irq), I'd suggest keeping just the long option, --ipi, like I
did for --on-threshold/--on-end (on Arnaldo's suggestion based on his
experience from perf [1]). This will make it clear to user the option
means "IPI detection" and not something else beginning with the letter
"i". We can always add a short option later if its use becomes common.

[1] https://lore.kernel.org/linux-trace-kernel/aEmWyPqQw2Ly7Jlu@x1/ (local)

Makes sense to me!

quoted

[truncated]

Tomas